[webkit-reviews] review granted: [Bug 116591] Fix issues with focus rings on search fields : [Attachment 202498] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 116591: Fix issues with focus rings on search fields
https://bugs.webkit.org/show_bug.cgi?id=116591

Attachment 202498: Patch
https://bugs.webkit.org/attachment.cgi?id=202498&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202498&action=review


> Source/WebKit/mac/WebView/WebHTMLView.mm:4953
> +    // Required to fix search field focus rings <rdar://problem/13780122>.

The use of "fix" here is not clear enough. It would be better if this comment
was more specific about what exactly AppKit does when we return YES here that
helps us. I tried to read your comment in the change log, but I couldn’t
understand it.