[webkit-reviews] review denied: [Bug 116604] [BlackBerry] Fix style issues in BlackBerry accelerated compositing backend : [Attachment 202529] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 22 06:40:19 PDT 2013
Arvid Nilsson <anilsson at rim.com> has denied Arvid Nilsson <anilsson at rim.com>'s
request for review:
Bug 116604: [BlackBerry] Fix style issues in BlackBerry accelerated compositing
backend
https://bugs.webkit.org/show_bug.cgi?id=116604
Attachment 202529: Patch
https://bugs.webkit.org/attachment.cgi?id=202529&action=review
------- Additional Comments from Arvid Nilsson <anilsson at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202529&action=review
> Source/WebCore/platform/graphics/blackberry/LayerCompositingThread.cpp:245
> + FloatQuad surfaceQuad = drawTransform.mapQuad(FloatRect(-origin(),
bounds()));
Oops, FloatQuad::FloatQuad(const FloatRect&) puts the rect corners in the wrong
positions, so the surface get "rotated" 90 degrees since the texture coords
used no longer matches the corners...
More information about the webkit-reviews
mailing list