[webkit-reviews] review granted: [Bug 116520] Have IDL interface names match their global constructor : [Attachment 202521] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 22 04:31:42 PDT 2013


Kentaro Hara <haraken at chromium.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 116520: Have IDL interface names match their global constructor
https://bugs.webkit.org/show_bug.cgi?id=116520

Attachment 202521: Patch
https://bugs.webkit.org/attachment.cgi?id=202521&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202521&action=review


Looks OK.

> Source/WebCore/Modules/mediastream/MediaStream.idl:32
> +    SkipVTableValidation,

BTW, I think you can remove [SkipVTableValidation]. [ImplementationLacksVTable]
and [ImplementationNamespace]. They were used in V8 binding only.


More information about the webkit-reviews mailing list