[webkit-reviews] review denied: [Bug 109350] Resource leak related to gstreamer and videos : [Attachment 202444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 21 11:39:16 PDT 2013


Jer Noble <jer.noble at apple.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 109350: Resource leak related to gstreamer and videos
https://bugs.webkit.org/show_bug.cgi?id=109350

Attachment 202444: Patch
https://bugs.webkit.org/attachment.cgi?id=202444&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
I don't believe this is the correct fix.  This will cause all state for the
media element to be lost whenever the element is removed from the dom (or
hidden with CSS).

Instead, this should be solved by running GC more often.  I'm very skeptical
that an unreferenced HTMLMediaElement will survive its associated WebView being
closed.


More information about the webkit-reviews mailing list