[webkit-reviews] review granted: [Bug 114870] [GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary : [Attachment 202426] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 21 07:53:43 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 114870: [GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
https://bugs.webkit.org/show_bug.cgi?id=114870

Attachment 202426: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=202426&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202426&action=review


> Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp:604
> +    if (isEndOfLine(visPos))

Please use visiblePosition here for the variable name.


More information about the webkit-reviews mailing list