[webkit-reviews] review denied: [Bug 115023] Editing: wrong text position when you click enter on the text behind the image : [Attachment 202196] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 115023: Editing: wrong text position when you click enter on the text
behind the image
https://bugs.webkit.org/show_bug.cgi?id=115023

Attachment 202196: Patch
https://bugs.webkit.org/attachment.cgi?id=202196&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202196&action=review


>
LayoutTests/editing/inserting/insert-paragraph-after-non-editable-node-before-t
ext.html:6
> +<span id="imgTest">text1<img src="broken-image"/>text2</span>

Please use abe.png or something and wait for load event on the image. Otherwise
this test can be flaky.

>
LayoutTests/editing/inserting/insert-paragraph-after-non-editable-node-before-t
ext.html:34
> +var test = document.getElementById('imgTest');
> +test.focus();
> +var selection = window.getSelection();
> +selection.collapse(test, test.childNodes.length - 1);
> +document.execCommand("InsertParagraph");
> +
> +test = document.getElementById('inputTest');
> +test.focus();
> +selection = window.getSelection();
> +selection.collapse(test, test.childNodes.length - 1);
> +document.execCommand("InsertParagraph");
> +
> +test = document.getElementById('objectTest');
> +test.focus();
> +selection = window.getSelection();
> +selection.collapse(test, test.childNodes.length - 1);
> +document.execCommand("InsertParagraph");
> +
> +

It seems like there are 3 test cases. Yet, we only dump the last one. r-
because of this.