[webkit-reviews] review granted: [Bug 116476] Active DOM object resumption should match reason for suspending : [Attachment 202334] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 20 23:21:30 PDT 2013


Joseph Pecoraro <joepeck at webkit.org> has granted Jeffrey Pfau
<jpfau at apple.com>'s request for review:
Bug 116476: Active DOM object resumption should match reason for suspending
https://bugs.webkit.org/show_bug.cgi?id=116476

Attachment 202334: Patch
https://bugs.webkit.org/attachment.cgi?id=202334&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202334&action=review


r=me

> Source/WebCore/ChangeLog:12
> +	   No new tests, code path should not be hit currently.

Nit: The code path is hit, there just isn't a change in behavior.

> Source/WebCore/dom/ScriptExecutionContext.h:179
> +    ActiveDOMObject::ReasonForSuspension
reasonForSuspendingActiveDOMObjects() { return
m_reasonForSuspendingActiveDOMObjects; }

const


More information about the webkit-reviews mailing list