[webkit-reviews] review granted: [Bug 116463] Clients should have a way to extend rendering suppression : [Attachment 202327] patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 116463: Clients should have a way to extend rendering suppression
https://bugs.webkit.org/show_bug.cgi?id=116463

Attachment 202327: patch
https://bugs.webkit.org/attachment.cgi?id=202327&action=review

------- Additional Comments from Andy Estes <aestes at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202327&action=review


> Source/WebCore/page/FrameView.h:426
> +    bool visualUpdatesAllowedByClient() { return
m_visualUpdatesAllowedByClient; }

This can be const-qualified.

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:87
> +WK_EXPORT WKRenderingSuppressionToken
WKBundlePageExtendIncrementalRenderingSuppression(WKBundlePageRef page)
WARN_UNUSED_RETURN;
> +WK_EXPORT void
WKBundlePageStopExtendingIncrementalRenderingSuppression(WKBundlePageRef page,
WKRenderingSuppressionToken token);

You don't need to name these arguments since their types are self-descriptive.

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4189
> +    unsigned token = ++m_maximumRenderingSuppressionToken;

Could be m_maximumRenderingSuppressionToken++ so that 0 is allowed to be a
token.