[webkit-reviews] review granted: [Bug 116334] Expose a way to know when forms are added to a page or when form controls are added to a form in the injected bundle : [Attachment 202328] Patch (version 2)

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 116334: Expose a way to know when forms are added to a page or when form
controls are added to a form in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116334

Attachment 202328: Patch (version 2)
https://bugs.webkit.org/attachment.cgi?id=202328&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202328&action=review


> Source/WebKit2/ChangeLog:20
> +	   (InjectedBundlePageFormClient):

It's best to remove such unhelpful lines from ChangeLogs (it's a bug in the
tool that it generates them).

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:133

> +    unsigned size = elements.size();

The type should be size_t.

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:135

> +    Vector<RefPtr<APIObject> > elementHandles;

We are now using C++11 ">>" in WebKit2 code (as well as in all Mac code).

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:138

> +    for (unsigned i = 0; i < size; ++i)

size_t

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:59
> +    void didAssociateFormControls(WebPage*, const
Vector<RefPtr<WebCore::Element> >&);

Same comment about ">>".

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:719
> +void WebChromeClient::didAssociateFormControls(const
Vector<RefPtr<WebCore::Element> >& elements)

Ditto.

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:173
> +    virtual void didAssociateFormControls(const
Vector<RefPtr<WebCore::Element> >&) OVERRIDE;

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:39
> +    virtual void didCreatePage(WKBundleRef, WKBundlePageRef);

OVERRIDE?