[webkit-reviews] review granted: [Bug 116464] PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess. : [Attachment 202321] Proposed patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted  review:
Bug 116464: PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned
WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=116464

Attachment 202321: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=202321&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202321&action=review


> Source/WebKit2/UIProcess/WebProcessProxy.cpp:208
> +    if (m_context->usesNetworkProcess() && !m_suddenTerminationCounter &&
canTerminateChildProcess())
>	   requestTermination();

Can you make this an early return instead?

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:210
> +	   static const double timeBeforeForcefullyKillingWebProcessInSeconds =
10;

I don’t think this needs to be static.

> Source/WebKit2/UIProcess/WebProcessProxy.cpp:662
> +    WTFLogAlways("Killing runaway web process, PID=%d\n",
processIdentifier());

Hue. Maybe lowercase pid?