[webkit-reviews] review denied: [Bug 114879] Incorrect computation of shrink-to-fit width for block with white-space:nowrap and floating children : [Attachment 200814] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 114879: Incorrect computation of shrink-to-fit width for block with
white-space:nowrap and floating children
https://bugs.webkit.org/show_bug.cgi?id=114879

Attachment 200814: Patch
https://bugs.webkit.org/attachment.cgi?id=200814&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200814&action=review


r-

> Source/WebCore/rendering/RenderBlock.cpp:5812
> +    bool shrinkToFit = (!isReplaced() && isFloatingOrOutOfFlowPositioned())
|| (isInlineBlockOrInlineTable() && !isTable());
> +    if (!style()->autoWrap() && !shrinkToFit && childrenInline()) {

Why special case shrinkToFit? If I'm understanding the bug correctly, it's that
we should ignore nowrap completely when computing min intrinsic sizes. Anyway,
you'd want to use something like:

RenderBox::sizesLogicalWidthToFitContent

to really catch all the shrink to fit cases, but I'm not convinced that it's
correct to do so. It sounds like minimum width is supposed to ignore
white-space if I'm understanding this correctly. You'll want to double check
and see if tables behave properly if we make that change though.