[webkit-reviews] review denied: [Bug 116215] background-color and text-decoration are not preserved when merging paragraphs : [Attachment 202264] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 116215: background-color and text-decoration are not preserved when merging
paragraphs
https://bugs.webkit.org/show_bug.cgi?id=116215

Attachment 202264: proposed patch
https://bugs.webkit.org/attachment.cgi?id=202264&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202264&action=review


> Source/WebCore/ChangeLog:8
> +	   New test -
editing/deleting/merge-paragraph-from-span-with-style.html

Nit: wrong format. This should appear after the long description but before
per-file description and should be in the form of:
Test: editing/deleting/merge-paragraph-from-span-with-style.html

See other change log entries that add tests.

> Source/WebCore/editing/EditingStyle.cpp:619
> -	   m_mutableStyle = copyEditingProperties(m_mutableStyle.get());
> +	   m_mutableStyle = copyEditingProperties(m_mutableStyle.get(),
removeNonInheritableEditingProperties ? OnlyInheritableEditingProperties :
AllEditingProperties);

Either this boolean means removeInheritableEditingProperties or that this code
is wrong. r- because of this.