[webkit-reviews] review granted: [Bug 116252] [CSS Regions][CSS Exclusions] shape-inside on regions should respect positioned shapes and overflow : [Attachment 202004] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 20 11:40:47 PDT 2013
Dave Hyatt <hyatt at apple.com> has granted Zoltan Horvath <zoltan at webkit.org>'s
request for review:
Bug 116252: [CSS Regions][CSS Exclusions] shape-inside on regions should
respect positioned shapes and overflow
https://bugs.webkit.org/show_bug.cgi?id=116252
Attachment 202004: proposed patch
https://bugs.webkit.org/attachment.cgi?id=202004&action=review
------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202004&action=review
r=me
> Source/WebCore/rendering/RenderBlockLineLayout.cpp:1729
> + LayoutUnit height = exclusionShapeInsideInfo->shapeLogicalTop()
- absoluteLogicalTop;
Minor nitpick. Call this logicalHeight and not just height.
More information about the webkit-reviews
mailing list