[webkit-reviews] review granted: [Bug 116349] [CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values : [Attachment 202166] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 116349: [CSS Exclusions] Add CSS parsing support for image URI shape-inside
and shape-outside values
https://bugs.webkit.org/show_bug.cgi?id=116349

Attachment 202166: Patch
https://bugs.webkit.org/attachment.cgi?id=202166&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202166&action=review


Thanks, looks good!

> LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js:61
> +    var unevaledString = '"' + value.replace(/\\/g, "\\\\").replace(/"/g,
"\"").replace(/\n/g, "\\n").replace(/\r/g, "\\r") + '"';

nit: I think you can use JSON.stringify() now.

> Source/WebCore/rendering/style/ExclusionShapeValue.h:66
> +    void setImage(PassRefPtr<StyleImage> v)

nit: use full names for variables/parameters.

> Source/WebCore/rendering/style/ExclusionShapeValue.h:74
> +    ExclusionShapeValue(PassRefPtr<BasicShape> shape) : m_type(Shape),
m_shape(shape) { }

nit: This is not WebKit style. You should have each member on a different line.