[webkit-reviews] review granted: [Bug 116406] Hoist several chunks of code at the top of RenderLayer::paintLayerContents() onto new functions : [Attachment 202226] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 116406: Hoist several chunks of code at the top of
RenderLayer::paintLayerContents() onto new functions
https://bugs.webkit.org/show_bug.cgi?id=116406

Attachment 202226: Patch
https://bugs.webkit.org/attachment.cgi?id=202226&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202226&action=review


r=me.

> Source/WebCore/rendering/RenderLayer.cpp:3691
> +bool RenderLayer::setupFontSubpixelQuantization(GraphicsContext* context,
bool &didQuantizeFonts)

& placement.

> Source/WebCore/rendering/RenderLayer.cpp:3725
> +    if (!style)
> +	   return false;

This could be an assertion instead; 'style' won't be null if the renderer has a
clip path.

> Source/WebCore/rendering/RenderLayer.h:939
> +    bool setupFontSubpixelQuantization(GraphicsContext*, bool
&didQuantizeFonts);

& placement.