[webkit-reviews] review granted: [Bug 116386] [EFL][WK2] Refactor ewk_view_custom_encoding_set/get API : [Attachment 202193] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 116386: [EFL][WK2] Refactor ewk_view_custom_encoding_set/get API
https://bugs.webkit.org/show_bug.cgi?id=116386

Attachment 202193: Patch
https://bugs.webkit.org/attachment.cgi?id=202193&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202193&action=review


Looks good. r=me with a few nit fixes.

> Source/WebKit2/ChangeLog:8
> +	   Refactor the API to handle 'const char*' paramerter in right way and


"parameter"

> Source/WebKit2/UIProcess/API/efl/EwkView.h:139
> +    const char* customTextEncodingName() {return m_customEncoding; }

Missing space after '{'. Why isn't the getter const anymore?