[webkit-reviews] review granted: [Bug 116336] Headers and footers will sometimes disappear and re-appear during page loads : [Attachment 202153] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 116336: Headers and footers will sometimes disappear and re-appear during
page loads
https://bugs.webkit.org/show_bug.cgi?id=116336

Attachment 202153: Patch
https://bugs.webkit.org/attachment.cgi?id=202153&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202153&action=review


>> Source/WebKit2/WebProcess/WebPage/mac/PageBannerMac.mm:77
>> +	[parentLayer->platformLayer() addSublayer:m_layer.get()];
> 
> GraphicsLayers own their sublayer tree, so if changes to the parentLayer get
flushed, that will nuke the sublayers. What prevents that from happening to
headers and footers?

We think this is OK because the banner GraphicsLayers are outside the normal
flush tree.