[webkit-reviews] review granted: [Bug 116338] [Windows] Don't use pdevenv when building with VS2010 : [Attachment 202132] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116338: [Windows] Don't use pdevenv when building with VS2010
https://bugs.webkit.org/show_bug.cgi?id=116338

Attachment 202132: Patch
https://bugs.webkit.org/attachment.cgi?id=202132&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=202132&action=review


r=me!

> Tools/ChangeLog:11
> +	   * Scripts/webkitdirs.pm:
> +	   (setupCygwinEnv): Check if we are using VS2005, and only use
> +	   the 'pdevenv' hack if we are. Otherwise, just build with
> +	   our standard project.

Might be worth mentioning somewhere in here that the VS2010 build is already
compiling files in parallel.