[webkit-reviews] review granted: [Bug 116240] [Mac] fast/flexbox/auto-height-with-flex.html fails intermittently : [Attachment 202117] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 116240: [Mac] fast/flexbox/auto-height-with-flex.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=116240

Attachment 202117: Patch
https://bugs.webkit.org/attachment.cgi?id=202117&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202117&action=review


r=me but consider my better if condition

> Source/WebCore/rendering/RenderFlexibleBox.cpp:529
> +	   if (contentLogicalHeight == LayoutUnit::max())
> +	       contentLogicalHeight -= borderPaddingAndScrollbar;

This should be:

    if (contentLogicalHeight > LayoutUnit::max() - borderPaddingAndScrollbar)

It’s also awkward to change contentLogicalHeight in place.