[webkit-reviews] review denied: [Bug 115281] WebKit tools cannot apply git patches for filenames containing spaces : [Attachment 201924] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 17 10:29:04 PDT 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has denied  review:
Bug 115281: WebKit tools cannot apply git patches for filenames containing
spaces
https://bugs.webkit.org/show_bug.cgi?id=115281

Attachment 201924: proposed patch
https://bugs.webkit.org/attachment.cgi?id=201924&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
I'm overriding darin's r+ with an r- because this doesn't have a test added for
the changes.

Tests for this method are in
Tools/Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl.

To run the tests, use:	./Tools/Scripts/test-webkitperl


More information about the webkit-reviews mailing list