[webkit-reviews] review granted: [Bug 116325] Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbitrary data blobs : [Attachment 202106] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 116325: Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support
loading arbitrary data blobs
https://bugs.webkit.org/show_bug.cgi?id=116325

Attachment 202106: Patch
https://bugs.webkit.org/attachment.cgi?id=202106&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202106&action=review


> Source/WebKit2/UIProcess/API/C/WKPage.h:369
> +WK_EXPORT void WKPageLoadData(WKPageRef page, WKDataRef data, WKStringRef
MIMEType, WKStringRef encoding, WKURLRef baseURL);
> +WK_EXPORT void WKPageLoadDataWithUserData(WKPageRef page, WKDataRef data,
WKStringRef MIMEType, WKStringRef encoding, WKURLRef baseURL, WKTypeRef
userData);

Do these need to be distinct? Can't we just have a userData param in LoadData?