[webkit-reviews] review granted: [Bug 116324] Make kit(Frame*) more robust : [Attachment 202104] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 116324: Make kit(Frame*) more robust
https://bugs.webkit.org/show_bug.cgi?id=116324

Attachment 202104: Patch
https://bugs.webkit.org/attachment.cgi?id=202104&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202104&action=review


> Source/WebKit/mac/WebView/WebFrame.mm:234
> +    FrameLoaderClient* frameLoaderClient = frame->loader()->client();
> +    if (frameLoaderClient->isEmptyFrameLoaderClient())
> +	   return nil;

Man that really stinks. I wondered why you were doing this refactoring.

I would have named the local variable just client.