[webkit-reviews] review granted: [Bug 116310] [CSSRegions] Constrain auto-height region computation in a different way : [Attachment 202077] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 116310: [CSSRegions] Constrain auto-height region computation in a
different way
https://bugs.webkit.org/show_bug.cgi?id=116310

Attachment 202077: Patch
https://bugs.webkit.org/attachment.cgi?id=202077&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202077&action=review


Looks good. Please, add a separate bug to track the other issue.

> Source/WebCore/ChangeLog:10
> +	   Covered by existing regions tests, since when replaced-based the
region had an intrinsic height of 0 and now, block-based, it does not have any
children.

We will need to add a test for regions with "box-sizing: border-box" and
"height: auto". Looks like both the previous and the new functions subtract the
padding out of your height.