[webkit-reviews] review granted: [Bug 116291] Minor String fixes in CSS : [Attachment 202046] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 116291: Minor String fixes in CSS
https://bugs.webkit.org/show_bug.cgi?id=116291

Attachment 202046: Patch
https://bugs.webkit.org/attachment.cgi?id=202046&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202046&action=review


r=me if you fix the thing I noticed, and get Qt and Windows building

> Source/WebCore/css/CSSPropertySourceData.cpp:92
> -    DEFINE_STATIC_LOCAL(String, emptyValue, (ASCIILiteral("e")));
> -    DEFINE_STATIC_LOCAL(String, importantSuffix, (ASCIILiteral("
!important")));
> -    if (!name && value == emptyValue)
> +    if (!name && value[0] == 'e')

This changes behavior. It now only checks that the first letter is e, rather
than checking that the entire string is "e". Is that OK? Is there test
coverage?