[webkit-reviews] review granted: [Bug 116250] Changes in text-only properties shouldn't cause repaints unless there is actually text. : [Attachment 202001] Second attempt

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 116250: Changes in text-only properties shouldn't cause repaints unless
there is actually text.
https://bugs.webkit.org/show_bug.cgi?id=116250

Attachment 202001: Second attempt
https://bugs.webkit.org/attachment.cgi?id=202001&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=202001&action=review


> Source/WebCore/rendering/RenderObject.cpp:1831
> -    if (updatedDiff == StyleDifferenceRepaintLayer || updatedDiff ==
StyleDifferenceRepaint) {
> +    if (updatedDiff == StyleDifferenceRepaintLayer || updatedDiff ==
StyleDifferenceRepaint || (updatedDiff == StyleDifferenceRepaintIfText &&
hasImmediateNonWhitespaceTextChild())) {

Might be nice to factor this increasingly complex condition to an inline
function.

> Source/WebCore/rendering/RenderObject.cpp:1875
> -	   if (m_parent && (diff == StyleDifferenceRepaint ||
newStyle->outlineSize() < m_style->outlineSize()))
> +	   if (m_parent && (diff == StyleDifferenceRepaint ||
newStyle->outlineSize() < m_style->outlineSize() || (diff ==
StyleDifferenceRepaintIfText && hasImmediateNonWhitespaceTextChild())))

Here too.