[webkit-reviews] review granted: [Bug 116292] Web Inspector: SyntaxError evaluating "1+1; //@ sourceURL=test" in console : [Attachment 202048] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 116292: Web Inspector: SyntaxError evaluating "1+1; //@ sourceURL=test" in
console
https://bugs.webkit.org/show_bug.cgi?id=116292

Attachment 202048: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=202048&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202048&action=review


> Source/WebCore/inspector/InjectedScriptSource.js:600
> +		   expression = "with ((window && window.console &&
window.console.__commandLineAPI) || {}) {\n" + expression + "\n}";

I didn't put the newlines back originally so the line numbers for the evaluated
expression would not change by adding the with() {}. Can you just add the
suffix newline and keep the prefix newline off?