[webkit-reviews] review granted: [Bug 116247] filter-build-webkit: Don't filter out the location of the missing symbol when linking fails : [Attachment 201992] Patch 3 of 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 15:43:28 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 116247: filter-build-webkit: Don't filter out the location of the missing
symbol when linking fails
https://bugs.webkit.org/show_bug.cgi?id=116247

Attachment 201992: Patch 3 of 3
https://bugs.webkit.org/attachment.cgi?id=201992&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201992&action=review


>
Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittest
s.pl:112
> +    my $lineLength = 200;

lineLength -> maxLineLength?


More information about the webkit-reviews mailing list