[webkit-reviews] review denied: [Bug 114781] [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing : [Attachment 198671] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu May 16 12:42:50 PDT 2013
Christophe Dumez <dchris at gmail.com> has denied Seokju Kwon
<seokju.kwon at gmail.com>'s request for review:
Bug 114781: [EFL] inspector-protocol/page/javascriptDialogEvents.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=114781
Attachment 198671: Patch
https://bugs.webkit.org/attachment.cgi?id=198671&action=review
------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=198671&action=review
> Source/WebKit/efl/ChangeLog:9
> +
Please check the following entry in efl-wk1 TestExpectations:
# EFL's DRT needs CONFIRM NAVIGATION messages
webkit.org/b/87246 fast/loader/form-submission-after-beforeunload-cancel.html [
Failure ]
If the test now passes please unskip it in this patch.
> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97
> + return EINA_TRUE;
You need to return !gTestRunner->shouldStayOnPageAfterHandlingBeforeUnload()
instead of unconditionally EINA_TRUE I believe. Please check other ports.
More information about the webkit-reviews
mailing list