[webkit-reviews] review denied: [Bug 98410] [WK2][WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method : [Attachment 195328] click() method for objects returned by eventSender.clontextClick()

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Wojciech Bielawski
<w.bielawski at samsung.com>'s request for review:
Bug 98410: [WK2][WKTR] WebKitTestRunner's eventSender.contextClick() returns
objects without implemented click() method
https://bugs.webkit.org/show_bug.cgi?id=98410

Attachment 195328: click() method for objects returned by
eventSender.clontextClick()
https://bugs.webkit.org/attachment.cgi?id=195328&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195328&action=review


Why doesn't that unskip tests on the Mac port. This code is common code.

> LayoutTests/ChangeLog:21
> +2013-03-27  Seokju Kwon  <seokju.kwon at gmail.com>
> +
> +	   [EFL] Remove a duplicated test from TestExpectations
> +	   https://bugs.webkit.org/show_bug.cgi?id=113385
> +
> +	   Unreviewed, EFL gardening.
> +
> +	   * platform/efl/TestExpectations:
> +

Trouble with your changelog.

> Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:45
> +typedef struct MenuItemPrivateData {

Why do you use typedef here?

> Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:46
> +    // This object has to own menu item because it is not possible to inform
JavaScript when context menu is closing

Missing period.

> Tools/WebKitTestRunner/InjectedBundle/EventSendingController.cpp:49
> +    MenuItemPrivateData(WKBundlePageRef _page, WKContextMenuItemRef _item) :
page(_page), item(_item) { }

Incorrect arguments names.