[webkit-reviews] review granted: [Bug 115656] Regression: Event#stopPropagation() does not halt bubbling for webkitTransitionEnd : [Attachment 201945] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 11:32:25 PDT 2013


Darin Adler <darin at apple.com> has granted Alexis Menard (darktears)
<alexis at webkit.org>'s request for review:
Bug 115656: Regression: Event#stopPropagation() does not halt bubbling for
webkitTransitionEnd
https://bugs.webkit.org/show_bug.cgi?id=115656

Attachment 201945: Patch
https://bugs.webkit.org/attachment.cgi?id=201945&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201945&action=review


I still think there are deficiencies in the test, but this is OK.

> Source/WebCore/dom/EventTarget.cpp:183
> +    const AtomicString prefixedTypeName = prefixedType(event);

Why the const?

> Source/WebCore/dom/EventTarget.cpp:192
> +	   const AtomicString unprefixedTypeName = event->type();

Why the const?


More information about the webkit-reviews mailing list