[webkit-reviews] review granted: [Bug 116128] [GTK] Add support for building WebCore to the cmake build : [Attachment 201773] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 116128: [GTK] Add support for building WebCore to the cmake build
https://bugs.webkit.org/show_bug.cgi?id=116128

Attachment 201773: Patch
https://bugs.webkit.org/attachment.cgi?id=201773&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201773&action=review


> Source/WebCore/ChangeLog:9
> +	   * platform/gtk/GtkVersioning.c: Include "config.h" since because we
removed

since because

> Source/WebCore/PlatformGTK.cmake:291
> +   
set_source_files_properties(platform/audio/gstreamer/WebKitWebAudioSourceGStrea
mer.cpp PROPERTIES COMPILE_DEFINITIONS "GLIB_DISABLE_DEPRECATION_WARNINGS=1")

This is a pretty neat feature of cmake, I must say.

> Source/cmake/OptionsGTK.cmake:126
> +CHECK_INCLUDE_FILES("GL/glx.h" GLX_FOUND)

I haven't figured out the upper/lowercase rules 100% yet, but this feels like
it should be lower.