[webkit-reviews] review granted: [Bug 116219] Fix Analyze ChangeLog's entry processing : [Attachment 201944] proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Peter Gal
<galpeter at inf.u-szeged.hu>'s request for review:
Bug 116219: Fix Analyze ChangeLog's entry processing
https://bugs.webkit.org/show_bug.cgi?id=116219

Attachment 201944: proposed patch
https://bugs.webkit.org/attachment.cgi?id=201944&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201944&action=review


>>> Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py:183
>>> +	     i = 0
>> 
>> Instead of doing that, exit early when "not entries".
> 
> That was my first try, but the 'entries' is a generator. So to do the early
exit first we need to ask for one element then check if there is any and do
some magic with it.

I see. Makes sense.