[webkit-reviews] review denied: [Bug 114960] Wrong text position when you click backspace on the line below the image : [Attachment 201189] Fix placement position when inserting as the last child of a node

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Wojciech Bielawski
<w.bielawski at samsung.com>'s request for review:
Bug 114960: Wrong text position when you click backspace on the line below the
image
https://bugs.webkit.org/show_bug.cgi?id=114960

Attachment 201189: Fix placement position when inserting as the last child of a
node
https://bugs.webkit.org/attachment.cgi?id=201189&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201189&action=review


> Source/WebCore/ChangeLog:8
> +	   Layout test added in separate patch:
https://bug-114960-attachments.webkit.org/attachment.cgi?id=201183

Please combine that patch into this.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1054
> +		       if (!insertAfterNode)
> +			   insertAfterNode = nodeToSplitTo.get();

This doesn't look right. We shouldn't be using the position after the
nodeToSplit ever.
We probably need to get the position before the nodeToSplitTo in this case.