[webkit-reviews] review granted: [Bug 116220] Frame flattening: crash when child iframe is removed during beforeload. : [Attachment 201946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 16 05:49:20 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Zalan Bujtas <zalan at apple.com>'s
request for review:
Bug 116220: Frame flattening: crash when child iframe is removed during
beforeload.
https://bugs.webkit.org/show_bug.cgi?id=116220

Attachment 201946: Patch
https://bugs.webkit.org/attachment.cgi?id=201946&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=201946&action=review


> Source/WebCore/page/FrameView.cpp:2660
> +    // layout() protects FrameView(), but it still can get destroyed, when
updateWidgets()

FrameView() -> FrameView
(and some unneeded commas)


More information about the webkit-reviews mailing list