[webkit-reviews] review denied: [Bug 116099] [Qt] UrlLoader::loadNext is broken in MiniBrowser : [Attachment 201701] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Hyungchan Kim
<inlinechan at gmail.com>'s request for review:
Bug 116099: [Qt] UrlLoader::loadNext is broken in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=116099

Attachment 201701: Patch
https://bugs.webkit.org/attachment.cgi?id=201701&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201701&action=review


> Tools/MiniBrowser/qt/UrlLoader.cpp:49
> +    connect(this, SIGNAL(loadSucceeded()), this, SLOT(frameLoadFinished()));

> +    connect(this, SIGNAL(loadFailed()), this, SLOT(frameLoadFinished()));

loadSucceeded and loadFailed have the same effect, and UrlLoader is unlikely
going to have external components using its API.
So no need to have two different signals, just use a loadFinished() signal that
is triggered by LoadSucceededStatus, LoadFailedStatus and LoadStoppedStatus.

> Tools/MiniBrowser/qt/UrlLoader.cpp:141
> +

We don't usually put an empty line between the cases.