[webkit-reviews] review granted: [Bug 116167] DocumentOrderedMap doesn't need to have two HashMaps : [Attachment 201913] Cleanup + accidental bug fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 116167: DocumentOrderedMap doesn't need to have two HashMaps
https://bugs.webkit.org/show_bug.cgi?id=116167

Attachment 201913: Cleanup + accidental bug fix
https://bugs.webkit.org/attachment.cgi?id=201913&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201913&action=review


r=me

> Source/WebCore/dom/SelectorQuery.cpp:101
> +const CSSSelector* SelectorDataList::canUseIdLookup(Node* rootNode) const

Since the return value changed, should we rename this? Something like
"selectorForIdLookup"?

> Source/WebCore/dom/SelectorQuery.cpp:131
> +	   const AtomicString idToMatch = idSelector->value();

Should be const AtomicString&.