[webkit-reviews] review denied: [Bug 113949] [EFL] --minimal build fails with error: invalid use of incomplete type `class WebKit::WebContextMenuItemData' : [Attachment 201373] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Ed Bartosh
<bartosh at gmail.com>'s request for review:
Bug 113949: [EFL] --minimal build fails with error: invalid use of incomplete
type `class WebKit::WebContextMenuItemData'
https://bugs.webkit.org/show_bug.cgi?id=113949

Attachment 201373: Patch
https://bugs.webkit.org/attachment.cgi?id=201373&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201373&action=review


> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:869
> +#endif

Please move this to a line above.

> Source/WebKit2/UIProcess/API/efl/ewk_context_menu_private.h:29
> +#if ENABLE(CONTEXT_MENUS)

Don't you need to wrap functions defined by this class up with
ENABLE(CONTEXT_MENU) as well ? For instance, appendItem(), removeItem().