[webkit-reviews] review denied: [Bug 115917] svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled : [Attachment 201897] Patch v2 - Better

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 115917: svg/as-image/img-zoom-svg-stylesheet.html crashes with
NetworkProcess enabled
https://bugs.webkit.org/show_bug.cgi?id=115917

Attachment 201897: Patch v2 - Better
https://bugs.webkit.org/attachment.cgi?id=201897&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201897&action=review


> Source/WebCore/loader/FrameLoaderClient.h:352
> +	   virtual bool isEmptyFrameLoaderClient() { return false; }

Please add a FIXME here with a bug to remove it and EmprtFrameLoaderClient,
which is an abomination.

> Source/WebKit2/WebProcess/Network/WebResourceLoadScheduler.cpp:120
> +    loadParameters.webPageID = webPage ? webPage->pageID() : 0;

This seems dangerous.  Please add assertions that these are not misused.