[webkit-reviews] review granted: [Bug 113619] FTL should force LLVM to use our own JIT memory allocator, and we shouldn't have to keep around an LLVMExecutionEngineRef to keep code alive : [Attachment 201889] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 113619: FTL should force LLVM to use our own JIT memory allocator, and we
shouldn't have to keep around an LLVMExecutionEngineRef to keep code alive
https://bugs.webkit.org/show_bug.cgi?id=113619

Attachment 201889: the patch
https://bugs.webkit.org/attachment.cgi?id=201889&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201889&action=review


r=me

> Source/JavaScriptCore/ftl/FTLCompile.cpp:43
> +static uint8_t *allocateCodeSection(

Move the star, please. And below.

> Source/JavaScriptCore/ftl/FTLCompile.cpp:54
> +	       state.graph.m_vm, size, state.graph.m_codeBlock,
JITCompilationMustSucceed);

Maybe link to the bug here about must succeed.