[webkit-reviews] review denied: [Bug 116140] Direct pattern compositing breaks when no-repeat is set on a large layer : [Attachment 201798] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Noam Rosenthal
<noam at webkit.org>'s request for review:
Bug 116140: Direct pattern compositing breaks when no-repeat is set on a large
layer
https://bugs.webkit.org/show_bug.cgi?id=116140

Attachment 201798: Patch
https://bugs.webkit.org/attachment.cgi?id=201798&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201798&action=review


> Source/WebCore/ChangeLog:10
> +	   Making sure that the solid color logic only overrides the
cotnentsRect if the background

Typo cotnentsRect

> Source/WebCore/rendering/RenderLayerBacking.cpp:894
>      updateDirectlyCompositedBackgroundImage(isSimpleContainer,
didUpdateContentsRect);
> +    if (didUpdateContentsRect)
> +	   return;
>      updateDirectlyCompositedBackgroundColor(isSimpleContainer,
didUpdateContentsRect);

It's not clear why you should bail if didUpdateContentsRect is true. Does that
mean you chose to use the background image path? Why does didUpdateContentsRect
indicate that, rather than the return value?

>>
LayoutTests/compositing/patterns/direct-pattern-compositing-contain-no-repeat-e
xpected.html:4
>> +	.composited { -webkit-transform: matrix3d(1, 0, 0, 0, 0, 1, 0, 0, 0, 0,
1, 0, 0, 0, 3, 1); }
> 
> I'd remove this from the reference.

Composited vs. non-composted refs break on Mac, alas.

But this should use translateZ() or something less mysterious.