[webkit-reviews] review granted: [Bug 115888] [BlackBerry] Unable to download blob resource : [Attachment 201809] update patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 15 13:48:36 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Mary Wu
<mary.wu at torchmobile.com.cn>'s request for review:
Bug 115888: [BlackBerry] Unable to download blob resource
https://bugs.webkit.org/show_bug.cgi?id=115888

Attachment 201809: update patch
https://bugs.webkit.org/attachment.cgi?id=201809&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201809&action=review


No problem with me on WebKit side. The blackberry bits were already reviewed
internally according to the changelog.

Just a question bellow.

> Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp:1240
> +    BlackBerry::Platform::DataStream *stream = new
BlackBerry::Platform::DataStream(netRequest);
> +    m_webPagePrivate->m_client->downloadRequested(stream, filename);
>      stream->streamOpen();

Who owns that memory?


More information about the webkit-reviews mailing list