[webkit-reviews] review granted: [Bug 116017] Remove an overloaded strokeRect in <canvas> : [Attachment 201541] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Dongseong Hwang
<dongseong.hwang at intel.com>'s request for review:
Bug 116017: Remove an overloaded strokeRect in <canvas>
https://bugs.webkit.org/show_bug.cgi?id=116017

Attachment 201541: Patch
https://bugs.webkit.org/attachment.cgi?id=201541&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201541&action=review


(In reply to comment #4)
> (From update of attachment 201541 [details])
> Is it really OK to remove this just because the standard chose not to include
this? How long has WebKit had this last argument? Is there content out there
that uses it?

I just checked, this version was there since upstreaming of WebKit.

I am also afraid of compatibility, especially with Dashboard. I check our
widgets and none of them use that version of strokeRect().

But I think this API is bad and we should probably align with the good stuff
here.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1117
> +    if (!(state().m_lineWidth >= 0))
>	   return;

Can you please move this branch after "if (!state().m_invertibleCTM)"?