[webkit-reviews] review granted: [Bug 116133] Printing in 1Password app is broken with screen fonts disabled : [Attachment 201788] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 21:22:50 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 116133: Printing in 1Password app is broken with screen fonts disabled
https://bugs.webkit.org/show_bug.cgi?id=116133

Attachment 201788: Patch
https://bugs.webkit.org/attachment.cgi?id=201788&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201788&action=review


> Source/WebCore/platform/mac/WebCoreSystemInterface.mm:213
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> +bool (*wkExecutableWasLinkedOnOrBeforeMountainLion)(void);
> +#endif

Doesn't look like this is called from WebCore, you can remove it.


More information about the webkit-reviews mailing list