[webkit-reviews] review requested: [Bug 116049] Add a DisplayAndPowerController class to handle IOKit Display and Power notifications : [Attachment 201778] patch

[bugzilla-daemon at webkit.org]

Roger Fong <roger_fong at apple.com> has asked  for review:
Bug 116049: Add a DisplayAndPowerController class to handle IOKit Display and
Power notifications
https://bugs.webkit.org/show_bug.cgi?id=116049

Attachment 201778: patch
https://bugs.webkit.org/attachment.cgi?id=201778&action=review

------- Additional Comments from Roger Fong <roger_fong at apple.com>
I've made some of the aforementioned changes.
In addition I've gotten rid of Power notifications and decided to leave that
where it is.
It was pointed out other platforms might not get their power and display
notifications from the same library like we do with IOKit so there's no reason
to really have them in the same place anyways.
The resulting class in a singleton DisplayNotificationObserver class.

I also believe that keeping track of the display state via s_screenDimmed and
having other classes (like FrameSelection) query said display state is the
cleanest way to do things for something this lightweight and specific in usage.
Plus now there's only two things in the IF PLATFORM(MAC) after getting rid of
that power stuff.