[webkit-reviews] review granted: [Bug 116121] [Mac] Add tests for secure event input : [Attachment 201756] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 14 14:31:27 PDT 2013


Mark Rowe (bdash) <mrowe at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 116121: [Mac] Add tests for secure event input
https://bugs.webkit.org/show_bug.cgi?id=116121

Attachment 201756: proposed patch
https://bugs.webkit.org/attachment.cgi?id=201756&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201756&action=review


> Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:222
> +		E1BA671D1742DA5A00C20251 /* Carbon.framework */ = {isa =
PBXFileReference; lastKnownFileType = wrapper.framework; name =
Carbon.framework; path =
../../../../../../System/Library/Frameworks/Carbon.framework; sourceTree =
"<group>"; };

This path isn't right. I think you need to mark it as relative to the SDK.


More information about the webkit-reviews mailing list