[webkit-reviews] review granted: [Bug 116114] [Windows] Identify proper run environment for scripts : [Attachment 201739] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116114: [Windows] Identify proper run environment for scripts
https://bugs.webkit.org/show_bug.cgi?id=116114

Attachment 201739: Patch
https://bugs.webkit.org/attachment.cgi?id=201739&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201739&action=review


r=me, but consider extracting the duplicate code into a method.

> Tools/Scripts/webkitdirs.pm:1627
>      my $programFilesPath = $ENV{'PROGRAMFILES(X86)'} || $ENV{'PROGRAMFILES'}
|| "C:\\Program Files";

Since this code is now duplicated in determineVisualStudioInstallDir(), should
we put this in a function?  I'd feel a little better if we did.