[webkit-reviews] review granted: [Bug 116079] [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools : [Attachment 201729] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116079: [Windows] Update ORWT to know about the Windows 8 SDK and Debug
Tools
https://bugs.webkit.org/show_bug.cgi?id=116079

Attachment 201729: Patch
https://bugs.webkit.org/attachment.cgi?id=201729&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201729&action=review


r=me

> Tools/Scripts/old-run-webkit-tests:2844
> +    my $ntsdPath = shift @possiblePaths;
> +
> +    while (not -f $ntsdPath) {
> +	   if (!@possiblePaths) {
> +	       print STDERR "Can't find ntsd.exe. Crash logs will not be
saved.\nSee
<http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs>.\n";
> +	       return;
>	   }
> +
> +	   $ntsdPath = shift @possiblePaths;

I think this might be a little clearer written as a for() loop, but I'm also
fine landing this version:

my $ntsdPath;
for ($ntsdPath = shift @possiblePaths; not -f $ntsdPath; $ntsdPath = shift
@possiblePaths) {
    if (…) { …}
}