[webkit-reviews] review granted: [Bug 116098] Snapshotted plug-ins shadow tree should reset style inheritance : [Attachment 201696] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 116098: Snapshotted plug-ins shadow tree should reset style inheritance
https://bugs.webkit.org/show_bug.cgi?id=116098

Attachment 201696: Patch
https://bugs.webkit.org/attachment.cgi?id=201696&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201696&action=review


> Source/WebCore/html/HTMLPlugInImageElement.cpp:370
> +    root->setResetStyleInheritance(true);

This needs a why comment. It’s not at all clear why this is here or what would
break if we removed this, and there’s no regression test to help make it clear.