[webkit-reviews] review denied: [Bug 116079] [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools : [Attachment 201650] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116079: [Windows] Update ORWT to know about the Windows 8 SDK and Debug
Tools
https://bugs.webkit.org/show_bug.cgi?id=116079

Attachment 201650: Patch
https://bugs.webkit.org/attachment.cgi?id=201650&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201650&action=review


> Tools/ChangeLog:24
> -2013-05-13  Zan Dobersek  <zdobersek at igalia.com>
> +

Uh?

> Tools/Scripts/old-run-webkit-tests:2846
> +    my $ntsdPath = File::Spec->catfile(toCygwinPath($ENV{PROGRAMFILES}),
"Windows Kits", "8.0", "Debuggers", "x64", "ntsd.exe");
>      unless (-f $ntsdPath) {
> -	   $ntsdPath = File::Spec->catfile(toCygwinPath($ENV{ProgramW6432}),
"Debugging Tools for Windows (x64)", "ntsd.exe");
> +	   $ntsdPath = File::Spec->catfile(toCygwinPath($ENV{PROGRAMFILES}),
"Windows Kits", "8.0", "Debuggers", "x86", "ntsd.exe");
>	   unless (-f $ntsdPath) {
> -	       $ntsdPath = File::Spec->catfile(toCygwinPath($ENV{SYSTEMROOT}),
"system32", "ntsd.exe");
> +	       $ntsdPath =
File::Spec->catfile(toCygwinPath($ENV{PROGRAMFILES}), "Debugging Tools for
Windows (x86)", "ntsd.exe");
>	       unless (-f $ntsdPath) {
> -		   print STDERR "Can't find ntsd.exe. Crash logs will not be
saved.\nSee
<http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs>.\n";
> -		   return;
> +		   $ntsdPath =
File::Spec->catfile(toCygwinPath($ENV{ProgramW6432}), "Debugging Tools for
Windows (x64)", "ntsd.exe");
> +		   unless (-f $ntsdPath) {
> +		       $ntsdPath =
File::Spec->catfile(toCygwinPath($ENV{SYSTEMROOT}), "system32", "ntsd.exe");
> +		       unless (-f $ntsdPath) {
> +			   print STDERR "Can't find ntsd.exe. Crash logs will
not be saved.\nSee
<http://trac.webkit.org/wiki/BuildingOnWindows#GettingCrashLogs>.\n";
> +			   return;
> +		       }
> +		   }
>	       }
>	   }
>      }

Instead of this crazy nesting, I think we should have a loop going over a list
of stuff we are looking for.

> Tools/Scripts/webkitdirs.pm:1657
> +return;

Uh?