[webkit-reviews] review granted: [Bug 112793] Modify checkLayout to receive the log container as an optional parameter : [Attachment 194071] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 13 18:27:24 PDT 2013


Darin Adler <darin at apple.com> has granted Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 112793: Modify checkLayout to receive the log container as an optional
parameter
https://bugs.webkit.org/show_bug.cgi?id=112793

Attachment 194071: Patch
https://bugs.webkit.org/attachment.cgi?id=194071&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194071&action=review


> LayoutTests/resources/check-layout.js:187
> +	   var container = overrideContainer;
> +	   if (!overrideContainer)
> +	       container = node.parentNode.className == 'container' ?
node.parentNode : node;

This can also be written:

    var container = overrideContainer || (node.parentNode.className ==
'container' ? node.parentNode : node);


More information about the webkit-reviews mailing list